Added Eigen header-only library #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
| file(COPY ${CURRENT_BUILDTREES_DIR}/src/eigen/COPYING.README DESTINATION ${CURRENT_PACKAGES_DIR}/share/eigen/COPYING.README) | ||
| file(RENAME ${CURRENT_PACKAGES_DIR}/share/eigen/COPYING.README ${CURRENT_PACKAGES_DIR}/share/eigen/copyright) | ||
|
|
||
| message(${CURRENT_BUILDTREES_DIR}) |
There was a problem hiding this comment.
Scripts should avoid printing extra information unless it's unique to this particular package (we can fix this during the merge).
There was a problem hiding this comment.
It seems it's fixed by the last commit (83f5e57).
There was a problem hiding this comment.
Ah, awesome, thanks 👍
traversaro
reviewed
Sep 21, 2016
| @@ -0,0 +1,3 @@ | |||
| Source: eigen | |||
There was a problem hiding this comment.
Quoting for the EXAMPLES.md file :
Second, determine a suitable package name. This should be ASCII, lowercase, and recognizable to someone who knows the library's "human name". If the library is already packaged in another package manager, prefer that name.
Eigen is known as:
- Eigen3 as CMake package (see
FindEigen3.cmakeandEigen3Config.cmakedistributed by the project). libeigen3-devin Debian-based systems.eigen3in FreeBSD [1]eigen3in MacPorts [2]eigenin homebrew [3]eigen3in fedora [4]eigenin Gentoo [5]eigen3in MINGW [6]
Given that (except for homebrew and gentoo's portage) the Eigen package is always called eigen3, it could make sense to call it eigen3 also in vcpkg?
[1] : https://svnweb.freebsd.org/ports/head/math/eigen3/
[2] : https://trac.macports.org/browser/trunk/dports/math/eigen3/Portfile
[3] : http://brewformulas.org/Eigen
[4] : http://rpms.famillecollet.com/rpmphp/zoom.php?rpm=eigen3
[5] : https://packages.gentoo.org/packages/dev-cpp/eigen
[6] : https://github.com/msys2/MINGW-packages/tree/44faea9dde7642988ed6e837d6a39d8effaea3f4/mingw-w64-eigen3
There was a problem hiding this comment.
Yes, this should definitely be renamed to eigen3! Great detective work.
|
Thanks! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
The following PRs are included: * hopefully fix crash in constraints (microsoft#60) * [vcpkg] allow --version to check the version (microsoft#50) * Remove baseline warning (microsoft#27) * [git] always pass autocrlf=false (microsoft#58) * ignore QtCreator CMake project files (microsoft#54) * ignore .DS_store files (microsoft#53) * [vcpkg] x-add-version now also checks if the manifest file is properly formatted (microsoft#43) * hopefully fix ci issue microsoft#16773 (microsoft#34) * Add docs to set VCPKG_ROOT to run tests (microsoft#45) * [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (microsoft#44) * add clang-format version to format-cxxcode (microsoft#41) * [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (microsoft#40) * [supports] Add `native` identifier expression and x-check-support command (microsoft#29) * [metrics] Split reporting of installs into name:triplet (microsoft#39) * [vcpkg] Improve error when accessing missing feature (microsoft#38) * [vcpkg] Allow shallow git registries (microsoft#37) * Disable git autocrlf when archiving tree (microsoft#36) * Use only named packages from extra registries (microsoft#35) * [registries] add metrics (microsoft#30) * Add vcpkg policy cmake helper port support (microsoft#17) * [osx] add support for rosetta (microsoft#23) * don't build tls12-download unless it's needed (microsoft#33) * Add new telemetry points for versioning (microsoft#21) * add cmake_minimum_required to vcpkg_tags (microsoft#25) * [x-add-versions] Perform atomic replacement of versioning files (microsoft#28) * [tools] support gsutil (microsoft#19) * add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (microsoft#26) * Add finite timeout on CURL metrics endpoint. (microsoft#22) * fix UB in make_error_code(utf8_errc) (microsoft#18)
Be-ing
added a commit
to Be-ing/vcpkg
that referenced
this pull request
Oct 19, 2021
add custom macOS triplet for Qt6
SchaichAlonso
pushed a commit
to PurpleFlowerGarden/vcpkg
that referenced
this pull request
Mar 31, 2022
Cairo: * Surface::Type: Deprecate WIN32, add WIN32_SURFACE (Kjell Ahlstedt) Issue microsoft#26, merge request !14 Build: * cairommconfig.h.*: Don't dllimport on MinGW (Chun-wei Fan) Merge reqest !16 (Chun-wei Fan) Issue gtkmm#90 (Lukas K.) * Meson build: Make it possible to use cairomm as a subproject (Kjell Ahlstedt) * Meson build: No implicit_include_directories (Kjell Ahlstedt) * MSVC build: exception.h: Export Cairo::logic_error selectively (Chun-wei Fan) Merge request !17
strega-nil-ms
pushed a commit
that referenced
this pull request
Apr 5, 2022
* [cairomm] update to 1.16.1 (#23903) Cairo: * Surface::Type: Deprecate WIN32, add WIN32_SURFACE (Kjell Ahlstedt) Issue #26, merge request !14 Build: * cairommconfig.h.*: Don't dllimport on MinGW (Chun-wei Fan) Merge reqest !16 (Chun-wei Fan) Issue gtkmm#90 (Lukas K.) * Meson build: Make it possible to use cairomm as a subproject (Kjell Ahlstedt) * Meson build: No implicit_include_directories (Kjell Ahlstedt) * MSVC build: exception.h: Export Cairo::logic_error selectively (Chun-wei Fan) Merge request !17 * [cairomm] remove patch (#23903) The WIN32 constant has been renamed to WIN32_SURFACE , and the WIN32 -> WIN32_SURFACE alias is only provided for non-win32 sytems, therefore our previous patch is no longer needed. * [cairomm] Support MSVC2022 (#23903) Manually add ed1ce9a630b375b0f43435e34fbe690eb8276178 from upstream, which prevents MSVC 2022 toolchains from being overridden by the meson port file, resulting in corrupted binarycache metadata * [cairomm] update version registries (#23903) * [cairomm] add license (#23903) * [cairomm] regenerate license registry (#23903) Co-authored-by: Schaich <alonso.schaich@sodgeit.de>
dempo93
pushed a commit
to dempo93/vcpkg
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12.